chore: use global bytelength variable

dcangulo · Aug 10, 2022 · bd13efb · bd13efb
1 parent ee5a0d7
commit bd13efb
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/CHANGELOGS.md b/CHANGELOGS.md
@@ -1,5 +1,8 @@
 # Changelogs
 
+## 5.1.0 (2022-08-10)
+* Used global bytelength variable.
+
 ## 5.0.1 (2022-08-10)
 * Removed extra files published to npm.
 

diff --git a/cpp/random-bytes.cpp b/cpp/random-bytes.cpp
@@ -20,7 +20,8 @@ namespace randombytes
                                                            const Value *arguments,
                                                            size_t count) -> Value
                                                         {
-                                                          vector<uint8_t> buffer(96, 0);
+                                                          int byteLength = arguments[0].getNumber();
+                                                          vector<uint8_t> buffer(byteLength, 0);
                                                           arc4random_buf(&buffer[0],
                                                                          buffer.size());
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-pkce-challenge",
-  "version": "5.0.2",
+  "version": "5.1.0",
   "description": "Proof Key for Code Exchange (PKCE) challenge generator for React Native",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",
@@ -31,7 +31,8 @@
     "react-native-macos",
     "PKCE",
     "oauth2",
-    "jsi"
+    "jsi",
+    "c++"
   ],
   "repository": {
     "type": "git",

diff --git a/src/generate-random-bytes.native.ts b/src/generate-random-bytes.native.ts
@@ -17,7 +17,7 @@ export default function generateRandomBytes(): string {
   }
 
   if ((global as any).RNPkceChallenge) {
-    const bytes = (global as any).RNPkceChallenge.randomBytes();
+    const bytes = (global as any).RNPkceChallenge.randomBytes(BYTE_LENGTH);
 
     return bytes;
   }