Fix issue with overlapping inlined basic embedded enums #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused when the inlining would made cddl-codegen think that the types were not overlapping since it was looking at the stored type not the actual starting cbor type (e.g. when it was a fixed value). This would cause a problem as the type matching introduced in #199 but only in very specific cases with basic groups starting with fixed values.
|
This one isn't related to the plutus datum tool but it's been open for a while. One of the issues fixes an issue with CML re-generation for the Nonce type which was that block that wasn't parsing last month. |
SebastienGllmt
approved these changes
May 17, 2024
src/generation.rs
Outdated
| } | ||
| _ => RustStructCBORLen::Fixed(1), | ||
| }; | ||
| // this will never be 1 line to don't bother with the below cases |
There was a problem hiding this comment.
not sure I understand what this comment means. Maybe to was meant to be so?
src/intermediate.rs
Outdated
| @@ -1310,6 +1310,7 @@ impl RustType { | |||
| }], | |||
| ConceptualRustType::Primitive(p) => p.cbor_types(), | |||
| ConceptualRustType::Rust(ident) => { | |||
| eprintln!("{ident:?}"); | |||
There was a problem hiding this comment.
Did you mean to leave in these two eprintln?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused when the inlining would made cddl-codegen think that the types were not overlapping since it was looking at the stored type not the actual starting cbor type (e.g. when it was a fixed value).
This would cause a problem as the type matching introduced in #199 but only in very specific cases with basic groups starting with fixed values.
Various other fixes + more test cases:
Fixes #229
Fixes #230
Fixes #231
Fixes #232