Range checks for types #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rooooooooob is this ready for review? |
|
I was just going to add more tests but I noticed I found some cases are not actually handled right. I'll try and see if I can get this fixed and ready today. |
now tests for both preserve-encodings and not with all 3 of those as well as bounds that go across both
|
@gostkin it's ready now. While making the test cases I noticed there were actually some annoying to solve cases not covered/implemented but now we should have everything covered for nint/uint/int with ranges above/below for preserve-encodings and without (+ the length ones for arrays/maps/text/bytes). |
gostkin
approved these changes
Nov 14, 2023
rooooooooob
added a commit
that referenced
this pull request
Dec 26, 2023
Specifically tests for support for #121 for plain groups. For multi arrays covered by #120 For single ones covered by #210 We are keeping #121 open for now as the case for single non-plain-groups e.g. `[uint]` is not covered. We've yet to see this used anywhere in Cardano so it's low priority to fix.
This was referenced Dec 26, 2023
rooooooooob
added a commit
that referenced
this pull request
Dec 27, 2023
Specifically tests for support for #121 for plain groups. For multi arrays covered by #120 For single ones covered by #210 We are keeping #121 open for now as the case for single non-plain-groups e.g. `[uint]` is not covered. We've yet to see this used anywhere in Cardano so it's low priority to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Range tests for all types (except floats). Ints, text, bytes, maps, arrays.
Covers preserve-encodings=true and =false.
Includes test cases for both.
also fixes some clippy warnings in generated code