Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support retrying interface exceptions during query execution #960

Merged
merged 18 commits into from
Dec 18, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Dec 4, 2024

requires: dbt-labs/dbt-adapters#368

docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@VersusFacit VersusFacit marked this pull request as ready for review December 5, 2024 02:21
@VersusFacit VersusFacit requested a review from a team as a code owner December 5, 2024 02:21
@VersusFacit VersusFacit self-assigned this Dec 5, 2024
dbt/adapters/redshift/connections.py Show resolved Hide resolved
hatch.toml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to revert all changes in this file.

pyproject.toml Show resolved Hide resolved
tests/unit/test_query.py Outdated Show resolved Hide resolved
hatch.toml Outdated
@@ -59,3 +59,6 @@ check-sdist = [
"pip freeze | grep dbt-redshift",
]
docker-prod = "docker build -f docker/Dockerfile -t dbt-redshift ."

[tool.hatch.metadata]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be in hatch.toml nor pyproject.toml to publish to PyPI. hatch build will fail since this is not reproducible.

Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rerunning CI after the version bump is merged into dbt-adapters should make it pass.

@colin-rogers-dbt colin-rogers-dbt enabled auto-merge (squash) December 18, 2024 21:08
@colin-rogers-dbt colin-rogers-dbt merged commit b3030ff into main Dec 18, 2024
23 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the addQueryRetries branch December 18, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants