Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-cast definition of unique_key in SnapshotConfig #11205

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Jan 9, 2025

Resolves #

Problem

Python caching of unique_key definition in SnapshotConfig causes deserialization errors because of wrong order.

Solution

Change definition from Optional[Union[str, List[str]]] to Union[str, List[str], None].

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gshank gshank requested a review from a team as a code owner January 9, 2025 19:55
@cla-bot cla-bot bot added the cla:yes label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@gshank gshank added Skip Changelog Skips GHA to check for changelog file artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking labels Jan 9, 2025
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this!

@gshank gshank merged commit e4d5a4e into main Jan 9, 2025
59 of 68 checks passed
@gshank gshank deleted the unique_key_deserialization_error branch January 9, 2025 21:03
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (b414ef2) to head (1ffb3d4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11205      +/-   ##
==========================================
- Coverage   88.88%   88.86%   -0.02%     
==========================================
  Files         187      187              
  Lines       24104    24104              
==========================================
- Hits        21425    21421       -4     
- Misses       2679     2683       +4     
Flag Coverage Δ
integration 86.17% <100.00%> (-0.02%) ⬇️
unit 62.40% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.40% <100.00%> (ø)
Integration Tests 86.17% <100.00%> (-0.02%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants