Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta config for dimensions, measures, and entities #11190

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

DevonFulcher
Copy link
Contributor

Problem

We want to support meta config for dimensions, measures, and entities.

Solution

This implements the same clobbering behavior as described here and implemented here.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@DevonFulcher DevonFulcher requested a review from a team as a code owner January 6, 2025 19:40
@cla-bot cla-bot bot added the cla:yes label Jan 6, 2025
@github-actions github-actions bot added the community This PR is from a community member label Jan 6, 2025
@DevonFulcher DevonFulcher added artifacts artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking semantic Issues related to the semantic layer and removed artifacts labels Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.88%. Comparing base (0bf38ce) to head (52a4b66).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11190      +/-   ##
==========================================
- Coverage   88.93%   88.88%   -0.06%     
==========================================
  Files         187      187              
  Lines       24057    24071      +14     
==========================================
  Hits        21395    21395              
- Misses       2662     2676      +14     
Flag Coverage Δ
integration 86.19% <92.85%> (-0.14%) ⬇️
unit 62.03% <21.42%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.03% <21.42%> (-0.03%) ⬇️
Integration Tests 86.19% <92.85%> (-0.14%) ⬇️

Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this

@ChenyuLInx ChenyuLInx merged commit 892c545 into main Jan 7, 2025
79 of 81 checks passed
@ChenyuLInx ChenyuLInx deleted the meta_config_for_dimensions,_measures,_and_entities branch January 7, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes community This PR is from a community member semantic Issues related to the semantic layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants