Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the default inputs on the integration tests workflow to match the branch #1435

Conversation

mikealfare
Copy link
Contributor

Problem

We're defaulting to main in integration tests for the adapter and core branches. The scheduled release branch tests don't pass inputs, so they check out 1.9.latest and then that workflow in turn checks out the default, main. This does not affect prior release branches since the functionality to select a branch was introduced after we cut the 1.8.latest branch.

Solution

  • update the defaults for dbt-core and dbt-bigquery to be 1.9.latest
  • handle future release branch tests in the monorepo

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Dec 12, 2024
@mikealfare mikealfare requested a review from a team as a code owner December 12, 2024 22:34
@cla-bot cla-bot bot added the cla:yes label Dec 12, 2024
@mikealfare mikealfare added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Dec 12, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@mikealfare
Copy link
Contributor Author

Here's a manual run of this workflow: https://github.com/dbt-labs/dbt-bigquery/actions/runs/12308203089

@colin-rogers-dbt colin-rogers-dbt merged commit 76a0dbb into 1.9.latest Dec 13, 2024
67 of 74 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the hotfix/1.9.latest/update-integration-test-defaults branch December 13, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants