raftstore: enable async-io by default. (tikv#16615)

close tikv#16614, ref pingcap/tidb#51585 Enable `async-io` by default with changing the setting `raftstore.store-io-pool-size` from 0 to 1. Signed-off-by: lucasliang <[email protected]> Signed-off-by: dbsid <[email protected]>
dbsid · Mar 24, 2024 · 21ba3bb · 21ba3bb
1 parent 84dc9d9
commit 21ba3bb
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/components/raftstore/src/store/config.rs b/components/raftstore/src/store/config.rs
@@ -500,7 +500,7 @@ impl Default for Config {
             local_read_batch_size: 1024,
             apply_batch_system: BatchSystemConfig::default(),
             store_batch_system: BatchSystemConfig::default(),
-            store_io_pool_size: 0,
+            store_io_pool_size: 1,
             store_io_notify_capacity: 40960,
             future_poll_size: 1,
             hibernate_regions: true,

diff --git a/etc/config-template.toml b/etc/config-template.toml
@@ -481,7 +481,7 @@
 
 ## Use how many threads to handle raft io tasks
 ## If it is 0, it means io tasks are handled in store threads.
-# store-io-pool-size = 0
+# store-io-pool-size = 1
 
 ## When the size of raft db writebatch exceeds this value, write will be triggered.
 # raft-write-size-limit = "1MB"

diff --git a/tests/integrations/config/dynamic/raftstore.rs b/tests/integrations/config/dynamic/raftstore.rs
@@ -237,6 +237,7 @@ fn test_update_raftstore_io_config() {
     // Start from SYNC mode.
     {
         let (mut resize_config, _dir) = TikvConfig::with_tmp().unwrap();
+        resize_config.raft_store.store_io_pool_size = 0; // SYNC mode
         resize_config.validate().unwrap();
         let (cfg_controller, _, _, mut system) = start_raftstore(resize_config, &_dir);