CB-4841 fix: doesn't show database auth login popup when filters enabled #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wroud
requested changes
Mar 28, 2024
Comment on lines
505
to
510
| runInAction(() => { | ||
| this.userData.filter = value; | ||
| this.userData.filter = value; | ||
|
|
||
| runInAction(() => { | ||
| for (const nodeState of this.state.values()) { | ||
| nodeState.showInFilter = false; | ||
| } |
There was a problem hiding this comment.
seems like case fix but not fix of the problem
actual problem is here:
explanation:
loadTree triggered concurrently with user change
userData updated but it state isn't applied yet
…ers enabled" This reverts commit 325f364.
…can-hardly-be-closed-after-relogin-with-an-applied-navigator-filter
Wroud
approved these changes
Mar 29, 2024
This reverts commit 6deccf2.
…can-hardly-be-closed-after-relogin-with-an-applied-navigator-filter
devnaumov
reviewed
Apr 4, 2024
| @@ -56,12 +56,10 @@ export class ConnectionAuthService extends Dependency { | |||
| return null; | |||
| } | |||
|
|
|||
| let connection = this.connectionInfoResource.get(key); | |||
| const connection = await this.connectionInfoResource.load(key, ['includeAuthNeeded', 'includeNetworkHandlersConfig', 'includeCredentialsSaved']); | |||
There was a problem hiding this comment.
We probably want to load the ['includeAuthNeeded', 'includeNetworkHandlersConfig', 'includeCredentialsSaved'] includes only if the function is near the network handlers initialization. This would avoid loading useless data, for example, if we are already connected and the function merely returns the connection.
…can-hardly-be-closed-after-relogin-with-an-applied-navigator-filter
…can-hardly-be-closed-after-relogin-with-an-applied-navigator-filter
…can-hardly-be-closed-after-relogin-with-an-applied-navigator-filter
Wroud
requested changes
Apr 9, 2024
serge-rider
deleted the
CB-4841-connection-auth-dialog-appears-and-can-hardly-be-closed-after-relogin-with-an-applied-navigator-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.