Skip to content

Commit

Permalink
dbeaver/pro#3885 Make CBSessionManager.createWebSessionImpl public
Browse files Browse the repository at this point in the history
  • Loading branch information
Ivan Gagarkin authored and Ivan Gagarkin committed Jan 6, 2025
1 parent 4ced918 commit 045556e
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -114,14 +114,14 @@ public WebSession getWebSession(
var baseWebSession = sessionMap.get(sessionId);
if (baseWebSession == null && CBApplication.getInstance().isConfigurationMode()) {
try {
webSession = createWebSessionImpl(new WebHttpRequestInfo(request));
webSession = createWebSession(new WebHttpRequestInfo(request));
} catch (DBException e) {
throw new DBWebException("Failed to create web session", e);
}
sessionMap.put(sessionId, webSession);
} else if (baseWebSession == null) {
try {
webSession = createWebSessionImpl(new WebHttpRequestInfo(request));
webSession = createWebSession(new WebHttpRequestInfo(request));
} catch (DBException e) {
throw new DBWebException("Failed to create web session", e);
}
Expand Down Expand Up @@ -182,7 +182,7 @@ public WebSession getOrRestoreWebSession(@NotNull WebHttpRequestInfo requestInfo
return null;
}

webSession = createWebSessionImpl(requestInfo);
webSession = createWebSession(requestInfo);
restorePreviousUserSession(webSession, oldAuthInfo);

sessionMap.put(sessionId, webSession);
Expand Down Expand Up @@ -216,7 +216,7 @@ private void restorePreviousUserSession(
}

@NotNull

Check warning on line 218 in server/bundles/io.cloudbeaver.server.ce/src/io/cloudbeaver/service/session/CBSessionManager.java

View workflow job for this annotation

GitHub Actions / Server / Lint

[checkstyle] reported by reviewdog 🐶 Missing a Javadoc comment. Raw Output: /github/workspace/./server/bundles/io.cloudbeaver.server.ce/src/io/cloudbeaver/service/session/CBSessionManager.java:218:5: warning: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck)
protected WebSession createWebSessionImpl(@NotNull WebHttpRequestInfo request) throws DBException {
public WebSession createWebSession(@NotNull WebHttpRequestInfo request) throws DBException {
return new WebSession(request, application, getSessionHandlers());
}

Expand Down

0 comments on commit 045556e

Please sign in to comment.