fix SSL through SSH jump #1179
Merged
fix SSL through SSH jump #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amne
force-pushed
the
fix/ssl_through_ssh_jump
branch
from
d3fd37b to
7eb0de1
Compare
amne
force-pushed
the
fix/ssl_through_ssh_jump
branch
from
7eb0de1 to
951721d
Compare
|
Thank you for the fix. |
|
hi @amjith , I think it should if it helps long-term. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to fix #1176
The error is caused by paramiko.channel.Channel class that implements a subset of python's socket API and cannot be properly wrapped in SSL because of this.
These changes replace the use of Channel with a straightforward approach of opening a python socket to local bound host and port of a tunnel to the jump host.
Checklist
changelog.md.AUTHORSfile (or it's already there).