bugfies to fix error catching and calling name

davidprowe · Jun 28, 2021 · bcf71e6 · bcf71e6
1 parent 9728e42
commit bcf71e6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/AD_SPN_Randomizer/GenerateRandomSPNs.ps1 b/AD_SPN_Randomizer/GenerateRandomSPNs.ps1
@@ -48,7 +48,10 @@
         $service = $services | get-Random
         $cn = $computer.Name
         $spn = "$service/$cn"
-        $user | Set-ADUser -ServicePrincipalNames @{Add=$spn}
+
+        Try { 
+        	$user | Set-ADUser -ServicePrincipalNames @{Add=$spn} -ErrorAction Stop
+        }Catch { $i--}
 
         $i++
     } While($i -lt $SPNCount)

diff --git a/Invoke-BadBlood.ps1 b/Invoke-BadBlood.ps1
@@ -161,7 +161,7 @@ if ($badblood -eq 'badblood') {
 
    write-host "Creating random SPNs" -ForegroundColor Green
    .($basescriptpath + '\AD_SPN_Randomizer\GenerateRandomSPNs.ps1')
-   CreateRandomSPNs -Count 50
+   CreateRandomSPNs -SPNCount 50