Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Webport configurable #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

linuxhelf
Copy link
Contributor

This change allows to change the port under which greenmail-http can be reached by setting the property uk.co.bigsoft.greenmail.web_port

For this to work, the frontend now uses the current browser url.
This means that if the firewall permits, the frontend can now also be used from a different computer, since the backend url is no longer hardcoded to localhost:7000.

This would break frontend development with yarn start, however setting "proxy" in package.json configures yarn to redirect all unknown request to this url.
Therefore yarn start still works and there should also no longer be any CORS problems.

@davidnewcomb
Copy link
Owner

Sounds good to me.

Please can you update the README and add a section under "Run with Access-Control-Allow-Origin" to describe this new option.

@linuxhelf
Copy link
Contributor Author

I've updated the readme, please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants