Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate profile description line to signals #926

Merged

Conversation

davidlj95
Copy link
Owner

Also, apply I of SOLID and just send the data to the component

@davidlj95 davidlj95 enabled auto-merge (squash) December 23, 2024 19:30
Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.31%. Comparing base (b619faa) to head (ff69a10).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
+ Coverage   98.30%   98.31%   +0.01%     
==========================================
  Files         121      122       +1     
  Lines         589      594       +5     
  Branches       60       61       +1     
==========================================
+ Hits          579      584       +5     
  Misses          6        6              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidlj95 davidlj95 force-pushed the stacked/refactor-migrate-profile-description-line-to-signals branch from b09340e to ff69a10 Compare December 23, 2024 19:51
@davidlj95 davidlj95 merged commit b0ba69c into main Dec 23, 2024
16 checks passed
@davidlj95 davidlj95 deleted the stacked/refactor-migrate-profile-description-line-to-signals branch December 23, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant