-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update to Angular v19 #845
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlj95
force-pushed
the
stacked/build-deps-update-to-angular-v19
branch
from
November 26, 2024 10:17
67eab22
to
3fe0aba
Compare
davidlj95
force-pushed
the
stacked/build-deps-update-to-angular-v19
branch
from
November 26, 2024 12:01
c1d1590
to
316bbbf
Compare
davidlj95
force-pushed
the
stacked/build-deps-update-to-angular-v19
branch
from
November 26, 2024 12:05
316bbbf
to
dd7f655
Compare
davidlj95
force-pushed
the
stacked/build-deps-update-to-angular-v19
branch
from
November 26, 2024 14:20
33bdc1d
to
72d1e51
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #845 +/- ##
==========================================
+ Coverage 95.76% 95.77% +0.01%
==========================================
Files 122 122
Lines 614 616 +2
Branches 76 76
==========================================
+ Hits 588 590 +2
Misses 20 20
Partials 6 6 ☔ View full report in Codecov by Sentry. |
davidlj95
force-pushed
the
stacked/build-deps-update-to-angular-v19
branch
from
November 26, 2024 14:35
2d74f0f
to
14be4bf
Compare
🚀 This pull request is included in v2.63.0. See v2.63.0 for release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to Angular v19
Configures Renovate to just update Angular v19 minors. Plus keep dependencies compatible with it
Ran all migrations:
true
: many changes aroundnode
entrypoint:server.ts
tsconfig.json
changed (though already changed, hmmm). Eventually no changes in diff.Changes needed:
makeItemFactory
doesn't properly infer after upgrading to Typescript 5.6. Adding manual types to solve it.Error: Unexpected "MockOfExperienceItemComponent" found in the "declarations" array of the "TestBed.configureTestingModule" call, "MockOfExperienceItemComponent" is marked as standalone and can't be declared in any NgModule - did you intend to import it instead (by adding it to the "imports" array)?
. This is because imports were overridden withTestBed.configureTestingModule
. However, what it does is it adds those to the root app injector, doesn't overwrite component imports. So in order to provide a fix,componentTestSetup
internal util is updated to useoverrideComponent
to replaceimports
in there.assert
towith
for importing JSON files.@types/node
was updated as otherwise a type in Angular SSR was invalid Type 'Http2ServerResponse' is not generic angular/angular-cli#28965ng build
no longer works neitherng test
when asset files do not exist. So generating them.onTabsChanged
is now executed beforesetupIntersectionObserver
. Refactors code to set elements to observe in a separate function and runs it as part ofsetupIntersectionObserver
.cy.mount
by declaring a specific component, it works. Also removes unneeded WebStorm inspection disable comment about unused alias as it now worksindex.html
is not outputted. So copyingindex.csr.html
asindex.html
for now.Also will need some changes in next PRs too:
@imports
#846