Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use symbolic links for git. #330

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

faassen
Copy link
Contributor

@faassen faassen commented Oct 21, 2024

When I ran git status I got this message:

warning: unable to access 'crates/macros/.gitignore': Too many levels of symbolic links
warning: unable to access 'crates/cli/.gitignore': Too many levels of symbolic links

Since git 2.23 .gitignore that is a symbolic link is ignored. I made them explicit now (though I'm not sure they're even needed)

Copy link
Collaborator

@Xenira Xenira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Might need some refinement later on, but should solve the issue.

Would like to fix CI before merging though.

Since git 2.23 .gitignore that is a symbolic link is ignored. I made them explicit now (though I'm not sure they're even needed)
@Xenira
Copy link
Collaborator

Xenira commented Oct 21, 2024

Rebased from master. Pipelines should succeed now.

@Xenira Xenira merged commit 45f71b3 into davidcole1340:master Oct 21, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants