Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward ClassEntry in create_object #277

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Forward ClassEntry in create_object #277

merged 4 commits into from
Nov 24, 2023

Conversation

joehoyle
Copy link
Collaborator

@joehoyle joehoyle commented Oct 24, 2023

See #138

The ce should be taken from the create_object. From that point on, everything else can carry on just about normal. the only thing that needs to change is the sanity check to make sure the ClassEntry for the object passed to the object handlers is a child as well as the direct class.

@joehoyle joehoyle marked this pull request as ready for review October 25, 2023 18:35
@joehoyle
Copy link
Collaborator Author

Ping @danog :)

@danog danog merged commit 4186cc4 into master Nov 24, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants