Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code streamlining #6

Closed
wants to merge 23 commits into from
Closed

Conversation

benjub
Copy link
Collaborator

@benjub benjub commented Apr 1, 2022

As described in #4 (comment)

@david-a-wheeler : I'm not sure which variable you were referring to. Also, this PR needs some review, in particular for the phrasing of the docstrings (maybe also by the original contributors @raphlinus and @sctfn). And maybe use your test-suite on it?

@benjub benjub mentioned this pull request Apr 4, 2022
@benjub
Copy link
Collaborator Author

benjub commented Apr 6, 2022

Closing since this PR is superseded by PR #7

@benjub benjub closed this Apr 6, 2022
@benjub benjub deleted the streamline branch April 6, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant