Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema: strict dates #177

Merged
merged 4 commits into from
Mar 3, 2022
Merged

Schema: strict dates #177

merged 4 commits into from
Mar 3, 2022

Conversation

mhuang74
Copy link
Contributor

@mhuang74 mhuang74 commented Mar 3, 2022

Schema (#60): add strict dates check

  • per Additional date/time data type inference for stats #174, would like to differentiate between DATE and DATETIME types, and add associated JSON Schema pattern constraints
  • refactored test to cover default (lenient) case where generated schema should not invalidate original input
  • updated test to include strict case where generated schema would invalidate adur dataset due to date format

@jqnatividad jqnatividad merged commit c318419 into dathere:master Mar 3, 2022
@mhuang74 mhuang74 mentioned this pull request Mar 3, 2022
Closed
@EricSoroos EricSoroos mentioned this pull request Apr 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhuang74 @jqnatividad