[APP-3696] Fix streaming value and improve error messages #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demchukilya
approved these changes
Jan 15, 2025
| @@ -10,7 +10,7 @@ | |||
| I18N_SPLASH_TITLE, I18N_SPLASH_TEXT, I18N_LOADING_MESSAGE, I18N_ACCESSIBILITY_LABEL_LLM, | |||
| ROLE_USER, I18N_ACCESSIBILITY_LABEL_YOU, I18N_NO_DEPLOYMENT_FOUND, | |||
| I18N_NO_DEPLOYMENT_ID, LLM_AVATAR, LLM_DISPLAY_NAME, USER_AVATAR, USER_DISPLAY_NAME, | |||
| ROLE_ASSISTANT, STATUS_ERROR) | |||
| ROLE_ASSISTANT, STATUS_ERROR, ENABLE_CHAT_API_STREAMING) | |||
There was a problem hiding this comment.
IMHO it's better to have each const on separate line.
Or just import constants and use constants.FOO
@demchukilya Thinking the same , what do you think of splitting into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository is public. Do not put any private DataRobot or customer data: code, datasets, model artifacts, .etc.
Rationale
Streaming should not be enabled by default as we currently only support GPT blueprints for it.
Furthermore the stream value should not be set at all - not even as False/None
Error handling has been improved to make it more clear when the error happened during a request or within the app.
Requests will show url and code/reason/message while processing issues show
Error while processing response from Chat API: ..<error message>Summary of Changes
Screenshots
Improved messages:
