[APP-3167] Add flask app based on the code from slack bot repo #1
Conversation
README.md
Outdated
| ``` | ||
|
|
||
| ## How to add and use runtime parameters? | ||
| Create a metadata.yaml file in your application source folder. Here is an example of a DEPLOYMENT_ID: |
There was a problem hiding this comment.
The MLOPS_RUNTIME_PARAM_ suffix is really confusing, and I think we should be really loud about its existance
| Create a metadata.yaml file in your application source folder. Here is an example of a DEPLOYMENT_ID: | |
| Create a metadata.yaml file in your application source folder. Here is an example of a DEPLOYMENT_ID which will create an environment variable called `MLOPS_RUNTIME_PARAM_DEPLOYMENT_ID`: |
There was a problem hiding this comment.
agree! Will add this text fix to the other OSS repos too 👍
| In the `./src/templates` directory you will find a sample index page. You can add additional HTML templates here, and | ||
| call them by adding new routes in the `flask_app.py` like this: | ||
| ```python | ||
| @flask_app.route("/new-page") |
There was a problem hiding this comment.
Won't this route need to be /apps/<app-id>/new-page?
There was a problem hiding this comment.
I got this piece from Chrsitians template code , where he used a proxy fix:
flask_app.wsgi_app = ProxyFix(flask_app.wsgi_app, x_prefix=1)
https://werkzeug.palletsprojects.com/en/2.3.x/middleware/proxy_fix/
src/start-app.sh
Outdated
|
|
||
| gunicorn -b :8080 flask_app:flask_app --timeout 200 --graceful-timeout 30 & |
There was a problem hiding this comment.
Does running via gunicorn automatically apply the prefix 👀 👀 👀 👀 👀 👀
There was a problem hiding this comment.
ProxyFix (previous comment) will do that, gunicorn gives us a production level server - the one that comes with Flask is only recommended for development, not prod
Add simple Flask app with Hello world sample.
The github files are copies of the other OSS templates, no changes have been made
Files of significance: