Fix and update deprecated primary field usage #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoGCh
commented
Dec 26, 2024
DiegoGCh
commented
Dec 30, 2024
|
The main and most important changes are inside the commits 1f1a53c and dc1489b. Which they fix the respective files so that either primary or primaryKey field is accepted as a way to create backwards compatibility. The more lengthy changes are only renames of occurrences from primary to primaryKey inside the commit a9812d2. Any feedback regarding this PR is welcome! @jochenchrist |
|
Great contribution, thanks |
This reverts commit b44971c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the use of the primaryKey field since primary is a deprecated field according to its usage in datacontract-specification and as indicated in datacontract.schema.json.
Edited the exporters, importers, examples, and Jinja templates that used the primary field to also accept the primaryKey field, thus generating backward compatibility.
Fixing the problem as mentioned in #518 .