Update 07-vector-shapefile-attributes-in-r.Rmd

[rfbrown]

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

In the line width example, the size aesthetic doesn't work (i.e., the lines are all the same size). We updated to linewidth as a proposed solution. However, we get the following warning (which also appears when using size), so this may not be the best fix: "Warning message: Using linewidth for a discrete variable is not advised."

[github-actions]

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

• 🎯 correct output
• 🖼️ correct figures
• ❓ new warnings
• ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/r-raster-vector-geospatial/compare/md-outputs..md-outputs-PR-448

The following changes were observed in the rendered markdown documents:

 07-vector-shapefile-attributes-in-r.md             |   6 +-
 config.yaml (new)                                  |  92 ++
 ...ributes-in-r-rendered-harv-paths-map-wide-1.png | Bin 31573 -> 33646 bytes
 md5sum.txt                                         |   2 +-
 renv.lock (new)                                    | 998 +++++++++++++++++++++
 5 files changed, 1096 insertions(+), 2 deletions(-)

What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-11-23 18:35:18 +0000

[rfbrown]

Note that this issue shows up again in the challenge, so the fix should be consistently applied throughout the lesson.

[Karel-Kroeze]

the warning is correct, it doesn't make a lot of sense to use a discrete value (that could be ordered in terms of 'size' of path, but isn't) and map it onto what is by convention if not definition an aesthetic usually used for continuous or at least ordered data.

That said, for illustrative purposes it's fine, and it might even be a good segue into letting learners think a bit about how best to visualize different types of attributes, and letting them know that ggplot2 has a lot of (usually very reasonable) opinions and defaults.

[jonjab]

this will also close #448