Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain original timeout behavior for compact #98

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Retain original timeout behavior for compact #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/thanos/compact.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,10 @@ func runCompact(
api.SetLoaded(blocks, err)
})

var syncMetasTimeout = conf.waitInterval
// Still use blockViewerSyncBlockTimeout to retain original behavior before this upstream change:
// https://github.com/databricks/thanos/commit/ab43b2b20cb42eca2668824a4084307216c6da2e#diff-6c2257b871fd1196514f664bc7e44cb21681215e0929710d0ad5ceea90b8e122R294
// Otherwise Azure won't work due to its high latency
var syncMetasTimeout = conf.blockViewerSyncBlockTimeout
if !conf.wait {
syncMetasTimeout = 0
}
Expand Down
Loading