Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querier ignore 'The specified key does not exist' error #97

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Querier ignore 'The specified key does not exist' error #97

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0e4f52
Querier ignore 'The specified key does not exist' error
hczhu-db Nov 7, 2024
0f908d3
Move the ignore logic inside group_replica branch
hczhu-db Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions pkg/store/proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,9 @@ type ProxyStore struct {
}

type proxyStoreMetrics struct {
emptyStreamResponses prometheus.Counter
storeFailureCount *prometheus.CounterVec
emptyStreamResponses prometheus.Counter
storeFailureCount *prometheus.CounterVec
missingBlockFileErrorCount prometheus.Counter
}

func newProxyStoreMetrics(reg prometheus.Registerer) *proxyStoreMetrics {
Expand All @@ -117,6 +118,10 @@ func newProxyStoreMetrics(reg prometheus.Registerer) *proxyStoreMetrics {
Name: "thanos_proxy_store_failure_total",
Help: "Total number of store failures.",
}, []string{"group", "replica"})
m.missingBlockFileErrorCount = promauto.With(reg).NewCounter(prometheus.CounterOpts{
Name: "thanos_proxy_querier_missing_block_file_error_total",
Help: "Total number of missing block file errors.",
})

return &m
}
Expand Down Expand Up @@ -421,11 +426,17 @@ func (s *ProxyStore) Series(originalRequest *storepb.SeriesRequest, srv storepb.
if resp.GetWarning() != "" {
totalFailedStores++
jnyi marked this conversation as resolved.
Show resolved Hide resolved
maxWarningBytes := 2000
shouldIgnore := strings.Contains(resp.GetWarning(), "The specified key does not exist")
warning := resp.GetWarning()[:min(maxWarningBytes, len(resp.GetWarning()))]
level.Error(s.logger).Log("msg", "Store failure with warning", "warning", warning)
level.Error(s.logger).Log("msg", "Store failure with warning", "warning", warning, "should_ignore", shouldIgnore)
// Don't have group/replica keys here, so we can't attribute the warning to a specific store.
s.metrics.storeFailureCount.WithLabelValues("", "").Inc()
if r.PartialResponseStrategy == storepb.PartialResponseStrategy_GROUP_REPLICA {
if shouldIgnore {
hczhu-db marked this conversation as resolved.
Show resolved Hide resolved
level.Warn(s.logger).Log("msg", "Ignore 'the specified key does not exist' error from Store")
// Ignore this error for now because we know the missing block file is already deleted by compactor.
// There is no other reason for this error to occur.
s.metrics.missingBlockFileErrorCount.Inc()
} else if r.PartialResponseStrategy == storepb.PartialResponseStrategy_GROUP_REPLICA {
// TODO: attribute the warning to the store(group key and replica key) that produced it.
// Each client streams a sequence of time series, so it's not trivial to attribute the warning to a specific client.
if totalFailedStores > 1 {
Expand Down
Loading