[PLAT-108920] adding another dedup iterator to merge samples instead of skipping them #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hczhu-db
reviewed
May 30, 2024
| const UseMergedSeries = "use_merged_series" | ||
|
|
||
| // mergedSeries is a storage.Series that implements a simple merge sort algorithm. | ||
| // when replicas has conflict values at the same timestamp, the first replica will be selected. |
There was a problem hiding this comment.
In our use case, there are no conflicting values wit the same timestamp because such data samples are rejected in the write path.
There was a problem hiding this comment.
oh, i meant it isn't exactly a merge sort, it will only keep 1 value at the same timestamp.
Comment on lines
+104
to
+107
| type Options struct { | ||
| GroupReplicaPartialResponseStrategy bool | ||
| EnableDedupMerge bool | ||
| } |
There was a problem hiding this comment.
This is much better than a simple var! We can add more options in the future.
…of skipping them Signed-off-by: Yi Jin <[email protected]>
hczhu-db
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raw data has 3 copies, one has missing data points
Before this change, dips in data points:
After this change:
Changes
Verification
More tests, especially during rolling update and the histogram used to have large spikes:
After the change it is gone: