[PLAT-108920] not skip samples during dedup #38
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of unit tests broken to be fixed, but the idea is currently both iters proceed and potentially skip data points in between. Instead, we only scan iterators and move forward if previous value is being used.
For example:
A: 1, 4, 5
B: 1, 2, 3, 4, 5
Before the change: dedup'ed result will be 1, 4, 5
After the change, the result will be 1, 2, 3, 4, 5
Changes
Verification