Add bytes fetched in query frontend #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchen-db
requested review from
a team,
christopherzli,
jnyi and
hczhu-db
and removed request for
a team
hczhu-db
reviewed
May 17, 2024
jnyi
reviewed
May 17, 2024
jnyi
reviewed
May 17, 2024
| for _, resp := range responses { | ||
| for _, hdr := range resp.GetHeaders() { | ||
| if hdr.GetName() == QueryBytesFetchedHeaderName { | ||
| for _, v := range hdr.Values { |
There was a problem hiding this comment.
curious why a header will have an array of values?
There was a problem hiding this comment.
jnyi
reviewed
May 17, 2024
do we need to modify the frontend code to show it on the UI? or in the header is enough? |
the header should be enough |
jnyi
reviewed
May 17, 2024
jnyi
approved these changes
May 17, 2024
hczhu-db
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add title
port forward querier and run query frontend locally
Changes
Verification