Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter] Add exporting of for_each_task in jobs #4347

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Dec 24, 2024

Changes

Resolves #4340

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@alexott alexott requested review from a team as code owners December 24, 2024 06:26
@alexott alexott requested review from renaudhartert-db and removed request for a team December 24, 2024 06:26
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4347
  • Commit SHA: f76198b880bcb3095a28a5c1e864c9fedb70d10e

Checks will be approved automatically on success.

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12477978731

@alexott alexott added the exporter TF configuration generator label Dec 29, 2024
@alexott alexott added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 83487ff Jan 7, 2025
12 checks passed
@alexott alexott deleted the exporter/foreach-task-support branch January 7, 2025 15:02
tanmay-db added a commit that referenced this pull request Jan 15, 2025
### New Features and Improvements

 * Add `fallback` to `databricks_external_location` ([#4372](#4372)).

### Bug Fixes

 * Send only what is required in Update of `databricks_credential` ([#4349](#4349)).

### Documentation

 * Add `MANAGE` privilege to the relevant UC resources ([#4371](#4371)).
 * Add a note about schema evolution and `databricks_sql_table` ([#4352](#4352)).
 * Add description of `clean_rooms_notebook_task` in `databricks_job` ([#4368](#4368)).
 * Add docs for cluster attributes for clusters assigned to groups ([#4359](#4359)).
 * Add note about use of `azurerm_databricks` for enhanced security settings ([#4393](#4393)).
 * Clarify views sharing in `databricks_share` ([#4378](#4378)).
 * Document job edit_mode ([#4354](#4354)).

### Internal Changes

 * Auto generated customizable schemas ([#4356](#4356)).
 * Disable `terraform fmt` in exporter to workaround build issues ([#4394](#4394)).
 * Fixed redundant optional owners in share resource and bumped Go SDK ([#4396](#4396)).
 * Load auto-generated resources and data sources ([#4367](#4367)).
 * Migrate workflows that need write access to use hosted runners ([#4377](#4377)).
 * Remove TF annotations on TFSDK models ([#4383](#4383)).
 * Restart Cluster before Library Installation ([#4384](#4384)).

### Dependency Updates

 * Bump github.com/zclconf/go-cty from 1.15.1 to 1.16.0 ([#4374](#4374)).
 * Bump github.com/zclconf/go-cty from 1.16.0 to 1.16.1 ([#4397](#4397)).

### Exporter

 * Add exporting of `for_each_task` in jobs ([#4347](#4347)).
 * Add references for missing permissions/grants types ([#4390](#4390)).
 * Support for group assigned clusters ([#4361](#4361)).
 * Use Go SDK to list clusters ([#4385](#4385)).
 * Use `Workspace.Export` from Go SDK for notebooks/files ([#4391](#4391)).
github-merge-queue bot pushed a commit that referenced this pull request Jan 16, 2025
### New Features and Improvements

* Add `fallback` to `databricks_external_location`
([#4372](#4372)).


### Bug Fixes

* Send only what is required in Update of `databricks_credential`
([#4349](#4349)).


### Documentation

* Add `MANAGE` privilege to the relevant UC resources
([#4371](#4371)).
* Add a note about schema evolution and `databricks_sql_table`
([#4352](#4352)).
* Add description of `clean_rooms_notebook_task` in `databricks_job`
([#4368](#4368)).
* Add docs for cluster attributes for clusters assigned to groups
([#4359](#4359)).
* Add note about use of `azurerm_databricks` for enhanced security
settings
([#4393](#4393)).
* Clarify views sharing in `databricks_share`
([#4378](#4378)).
* Document job edit_mode
([#4354](#4354)).


### Internal Changes

* Auto generated customizable schemas
([#4356](#4356)).
* Disable `terraform fmt` in exporter to workaround build issues
([#4394](#4394)).
* Fixed redundant optional owners in share resource and bumped Go SDK
([#4396](#4396)).
* Load auto-generated resources and data sources
([#4367](#4367)).
* Migrate workflows that need write access to use hosted runners
([#4377](#4377)).
* Remove TF annotations on TFSDK models
([#4383](#4383)).
* Restart Cluster before Library Installation
([#4384](#4384)).


### Dependency Updates

* Bump github.com/zclconf/go-cty from 1.15.1 to 1.16.0
([#4374](#4374)).
* Bump github.com/zclconf/go-cty from 1.16.0 to 1.16.1
([#4397](#4397)).


### Exporter

* Add exporting of `for_each_task` in jobs
([#4347](#4347)).
* Add references for missing permissions/grants types
([#4390](#4390)).
* Support for group assigned clusters
([#4361](#4361)).
* Use Go SDK to list clusters
([#4385](#4385)).
* Use `Workspace.Export` from Go SDK for notebooks/files
([#4391](#4391)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter TF configuration generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Exporter] Add export for ForEach task in jobs
3 participants