-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fixes to Azure #114
base: main
Are you sure you want to change the base?
Add fixes to Azure #114
Conversation
thanks for the contribution @sajohnstone! |
Thanks @sajohnstone this looks great! I happen to be working on a refactor myself, addressing some of these exact things. I'm working on a review of your changes and am looking forward to collaborating. Would you be willing to review my changes as well as collaborate on the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions/finds on my end. Agree with @nathanknox - I know he has a few changes in flight and it might be good to review his PR also when it is ready.
@nathanknox yes, very happy to review your PR and work in collaboration. |
I have
To add a bit of context to the above, we've found that making things optional makes it much easier for testing, but also for deployments into environments that already have UC.