Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes to Azure #114

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

sajohnstone
Copy link

@sajohnstone sajohnstone commented Dec 6, 2024

I have

  1. Added a make file and updated the readme
  2. Fixed missing application_id
  3. Made KeyVault, Firewall, UC Creation and Test VM as optional
  4. Small refactor to put locals into locals.tf and datasoruces in datasources.tf
    To add a bit of context to the above, we've found that making things optional makes it much easier for testing, but also for deployments into environments that already have UC.

@JDBraun
Copy link
Contributor

JDBraun commented Dec 9, 2024

thanks for the contribution @sajohnstone!

cc: @nathanknox @connorbrown-db @eliswanson-db

@nathanknox
Copy link
Contributor

Thanks @sajohnstone this looks great! I happen to be working on a refactor myself, addressing some of these exact things. I'm working on a review of your changes and am looking forward to collaborating. Would you be willing to review my changes as well as collaborate on the PR?

Copy link
Contributor

@connorbrown-db connorbrown-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions/finds on my end. Agree with @nathanknox - I know he has a few changes in flight and it might be good to review his PR also when it is ready.

azure/tf/modules/azure_hub/unitycatalog.tf Show resolved Hide resolved
azure/tf/modules/azure_hub/routetable.tf Outdated Show resolved Hide resolved
azure/tf/modules/azure_spoke/adb_workspace.tf Outdated Show resolved Hide resolved
makefile Show resolved Hide resolved
@sajohnstone
Copy link
Author

@nathanknox yes, very happy to review your PR and work in collaboration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants