Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README #110

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Improve README #110

merged 6 commits into from
Jun 11, 2024

Conversation

pietern
Copy link
Collaborator

@pietern pietern commented Jun 6, 2024

No description provided.

Copy link
Contributor

@lennartkats-db lennartkats-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Minor comments

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@pietern pietern requested a review from lennartkats-db June 6, 2024 10:36
Copy link

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

@@ -63,7 +63,7 @@ if [ ! -w "$TARGET" ]; then
echo "Please run this script through 'sudo' to allow writing to $TARGET."
echo
echo "If you're running this script from a terminal, you can do so using"
echo " curl -fsSL https://raw.githubusercontent.com/databricks/setup-cli/main/install.sh | sudo sh"
echo " curl -fsSL https://raw.githubusercontent.com/databricks/setup-cli/v${VERSION}/install.sh | sudo sh"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we should definitely be using the install script from the tagged versions of the repo.

@pietern pietern dismissed lennartkats-db’s stale review June 11, 2024 12:56

Applied suggestions

@pietern pietern merged commit 15d291a into main Jun 11, 2024
15 checks passed
@pietern pietern deleted the update-readme branch June 11, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants