Skip to content

Commit

Permalink
Run shellcheck from action (#112)
Browse files Browse the repository at this point in the history
This prevents new failing checks from being committed.

Also see #102.
  • Loading branch information
pietern authored Jun 6, 2024
1 parent de068a8 commit 7c81ed8
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 2 deletions.
16 changes: 16 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -209,3 +209,19 @@ jobs:
- name: Assert installation path is ~/bin
run: ./setup-cli/assert/path.sh ~/bin/databricks
shell: bash

shellcheck:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
with:
path: ./setup-cli

- name: Install shellcheck
run: sudo apt-get install shellcheck
shell: bash

- name: Run shellcheck
run: shellcheck ./setup-cli/*.sh
shell: bash
2 changes: 1 addition & 1 deletion install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ unzip -q "${FILE}.zip"
# Add databricks to path.
chmod +x ./databricks
cp ./databricks "$TARGET"
echo "Installed $($TARGET/databricks -v) at $TARGET/databricks."
echo "Installed $("$TARGET/databricks" -v) at $TARGET/databricks."

# Clean up temporary directory.
cd "$OLDPWD"
Expand Down
2 changes: 1 addition & 1 deletion setup_release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ fi

# Pull latest version from VERSION file if not set.
if [ -z "${VERSION:-}" ]; then
VERSION=$(cat $(dirname "$0")/VERSION)
VERSION=$(cat "$(dirname "$0")"/VERSION)
fi

FILE="databricks_cli_$VERSION"
Expand Down

0 comments on commit 7c81ed8

Please sign in to comment.