[PECO-1083] Updated thrift files and added check for protocol version #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nithinkdb
requested review from
susodapop,
arikfr,
yunbodeng-db and
andrefurlan-db
as code owners
susodapop
reviewed
Sep 26, 2023
Signed-off-by: nithinkdb <[email protected]>
Signed-off-by: nithinkdb <[email protected]>
Signed-off-by: nithinkdb <[email protected]>
nithinkdb
force-pushed
the
PECO-1083
branch
from
8438ab8 to
52f7abb
Compare
Signed-off-by: nithinkdb <[email protected]>
susodapop
reviewed
Sep 29, 2023
susodapop
approved these changes
Sep 29, 2023
Co-authored-by: Jesse <[email protected]>
|
Hey there, did you run the e2e tests for this before merging? They all fail in the case where DBR doesn't return |
susodapop
pushed a commit
that referenced
this pull request
Oct 1, 2023
…otocol version (#229)" This reverts commit 241e934. Signed-off-by: Jesse Whitehouse <[email protected]>
susodapop
pushed a commit
that referenced
this pull request
Oct 2, 2023
…otocol version (#229)" This reverts commit 241e934. Signed-off-by: Jesse Whitehouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we've migrated to a new version of runtime that supports parameterized queries, we need to add a protocol check to ensure that the server side is up to date in supporting such queries. Hence, we're updating the thrift files to access the new protocol, and adding a version check when doing parameterized queries.