Skip to content

Commit

Permalink
Remove outdated comment now that we better understand how to use this…
Browse files Browse the repository at this point in the history
… file

Signed-off-by: Jesse Whitehouse <[email protected]>
  • Loading branch information
Jesse Whitehouse committed Oct 8, 2023
1 parent e233058 commit 214523b
Showing 1 changed file with 0 additions and 23 deletions.
23 changes: 0 additions & 23 deletions src/databricks/sqlalchemy/requirements.py
Original file line number Diff line number Diff line change
@@ -1,20 +1,4 @@
"""
This module is supposedly used by the compliance tests to control which tests are run based on database capabilities.
However, based on some experimentation that does not appear to be consistently the case. Until we better understand
when these requirements are and are not implemented, we prefer to manually capture the exact nature of the failures
and errors.
Once we better understand how to use requirements.py, an example exclusion will look like this:
import sqlalchemy.testing.requirements
import sqlalchemy.testing.exclusions
class Requirements(sqlalchemy.testing.requirements.SuiteRequirements):
@property
def __some_example_requirement(self):
return sqlalchemy.testing.exclusions.closed
The complete list of requirements is provided by SQLAlchemy here:
https://github.com/sqlalchemy/sqlalchemy/blob/main/lib/sqlalchemy/testing/requirements.py
Expand All @@ -23,13 +7,6 @@ def __some_example_requirement(self):
import sqlalchemy.testing.requirements
import sqlalchemy.testing.exclusions

import logging

logger = logging.getLogger(__name__)

logger.warning("requirements.py is not currently employed by Databricks dialect")


class Requirements(sqlalchemy.testing.requirements.SuiteRequirements):
@property
def date_historic(self):
Expand Down

0 comments on commit 214523b

Please sign in to comment.