fix(#244): Error When Freezing Array.prototype #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a project does freezing of Array prototypes this breaks it, even tho the node version is greater than 16
BikashMcKinsey
requested review from
arikfr,
superdupershant,
yunbodeng-db,
kravets-levko,
andrefurlan-db,
rcypher-databricks,
jackyhu-db and
benc-db
as code owners
BikashMcKinsey
changed the title
BikashMcKinsey
changed the title
BikashMcKinsey
changed the title
|
Fixes #244 |
|
closing this PR since a request is already raised #242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a particular file, the
Array.prototypeis being frozen which is causing compatibility issues. The issue arises when theatmethod is added to theArray.prototypeafter it has been frozen, resulting in an error.Steps to reproduce:
atmethod.Expected behavior:
The application should run without errors.
Actual behavior:
An error occurs when running the application due to the
Array.prototypebeing frozen before theatmethod is added.Proposed solution:
Modify the code to conditionally add the
atmethod to theArray.prototypeonly if it doesn't already exist.