Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove limit for sockets per connection to fix "Premature close" error + prepare patch release #217

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

kravets-levko
Copy link
Contributor

Fixes #208

Signed-off-by: Levko Kravets <[email protected]>
Copy link

@susodapop susodapop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping for now. Is there any possibility of a runaway condition where we recursively create many, many more sockets?

@kravets-levko
Copy link
Contributor Author

maxSockets: Infinity is basically a default value since some very early Node version, I just made it more explicit. In combination with socket timeout, I think Node can deal with it. In the worst case, user will get some error when system limit reached. Also, later we're going to make Agent customizable and allow user to tweak those settings

@kravets-levko kravets-levko merged commit c85629b into main Jan 16, 2024
5 checks passed
@kravets-levko kravets-levko deleted the remove-sockets-limit branch January 16, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

databricks : FetchError due to Premature close!
2 participants