Only use from_dict when using headers

databricks · Feb 16, 2024 · dd6bd52 · dd6bd52
1 parent 30f21a2
commit dd6bd52
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 9 deletions.
diff --git a/.codegen/service.py.tmpl b/.codegen/service.py.tmpl
@@ -328,9 +328,13 @@ class {{.Name}}API:{{if .Description}}
 {{- end}}
 
 {{define "deserialize-stream" -}}
-deserialized = {{.Response.PascalName}}.from_dict(res)
+    {{if or .Response.HasJsonField .Response.HasHeaderField -}}
+        deserialized = {{.Response.PascalName}}.from_dict(res)
         {{.Response.PascalName}}.{{.ResponseBodyField.CamelName}}=content
         return deserialized
+    {{- else -}}
+        return {{.Response.PascalName}}({{.ResponseBodyField.CamelName}}=res)
+    {{end}}
 {{- end}}
 
 {{define "method-do" -}}

diff --git a/databricks/sdk/service/billing.py b/databricks/sdk/service/billing.py
diff --git a/databricks/sdk/service/files.py b/databricks/sdk/service/files.py
diff --git a/databricks/sdk/service/sql.py b/databricks/sdk/service/sql.py
diff --git a/tests/integration/test_files.py b/tests/integration/test_files.py
@@ -222,7 +222,7 @@ def test_files_api_upload_download(ucws, random):
             target_file = f'/Volumes/main/{schema}/{volume}/filesit-{random()}.txt'
             w.files.upload(target_file, f)
             m = w.files.get_metadata(target_file)
-            assert m.content_type == 'text/plain'
+            assert m.content_type == 'application/octet-stream'
             with w.files.download(target_file).contents as f:
                 assert f.read() == b"some text data"