Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]Add support for discovery URL #336

Merged
merged 10 commits into from
Aug 30, 2024
Merged

[Feature]Add support for discovery URL #336

merged 10 commits into from
Aug 30, 2024

Conversation

samikshya-db
Copy link
Contributor

@samikshya-db samikshya-db commented Aug 28, 2024 •
edited
Loading

Changes

  • The current state of SDK : OAuth Token and auth endpoints: we build the discovery endpoint from the host url set in DatabricksConfig.
  • The changed state in SDK : We fetch the token endpoint and auth endpoint from discovery endpoint. This is useful for scenarios when customers have their own auth endpoints.

Tests

  • Manually tested using SQL driver
  • Also added unit tests

@samikshya-db samikshya-db marked this pull request as ready for review August 28, 2024 04:27
@samikshya-db samikshya-db requested a review from gopalldb August 28, 2024 04:27
@samikshya-db samikshya-db changed the title Add support for discovery URL Add support for discovery URL. [tests pending] Aug 28, 2024
@samikshya-db samikshya-db changed the title Add support for discovery URL. [tests pending] [Feature] Add support for discovery URL. [tests pending] Aug 28, 2024
jayantsing-db

This comment was marked as off-topic.

Sign in to view

@jayantsing-db jayantsing-db self-requested a review August 28, 2024 07:35
@samikshya-db samikshya-db added the enhancement New feature or request label Aug 28, 2024
@jayantsing-db jayantsing-db requested review from jayantsing-db and removed request for jayantsing-db August 28, 2024 07:38
@samikshya-db samikshya-db changed the title [Feature] Add support for discovery URL. [tests pending] [Feature] Add support for discovery URL Aug 28, 2024
@samikshya-db samikshya-db changed the title [Feature] Add support for discovery URL [Feature]Add support for discovery URL Aug 28, 2024
@samikshya-db samikshya-db requested a review from mgyucht August 29, 2024 04:38
mgyucht
mgyucht approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, otherwise, LGTM!

databricks-sdk-java/src/main/java/com/databricks/sdk/core/DatabricksConfig.java Outdated Show resolved Hide resolved
@samikshya-db samikshya-db force-pushed the samikshya-db/newmergedChanges branch from 220ae32 to 9e66663 Compare August 29, 2024 09:18
samikshya-db and others added 8 commits August 29, 2024 14:54
@samikshya-db
Add tests
a3a63e4
@samikshya-db
Add javadoc
234bb94
@samikshya-db
fmt
82909a8
@samikshya-db
fmt
6825ae6
@vikrantpuppala @samikshya-db
[Feature] Add a way to provide non proxy hosts (databricks#331)
cbec97a 
## Changes
<!-- Summary of your changes that are easy to understand -->
Add a new config in proxy hosts to provide non proxy hosts. Related
system property info here:
https://docs.oracle.com/javase/8/docs/technotes/guides/net/proxies.html

## Tests
<!-- How is this tested? -->
Tested locally and via unit tests
@vikrantpuppala @samikshya-db
[Feature] Provide SSLSocketFactory in HttpClient (databricks#333)
1c5b624 
## Changes
<!-- Summary of your changes that are easy to understand -->
We need to provide a way for clients to specify their own SSL socket
factory in case they want to handle TLS connections in a different way

## Tests
<!-- How is this tested? -->
Unit tests and local testing
@samikshya-db
make naming better
199c45b
@samikshya-db @mgyucht
Update databricks-sdk-java/src/main/java/com/databricks/sdk/core/Data…
f875bb1 
…bricksConfig.java

Co-authored-by: Miles Yucht <[email protected]>
@samikshya-db samikshya-db force-pushed the samikshya-db/newmergedChanges branch from 9e66663 to f875bb1 Compare August 29, 2024 09:26
@mgyucht mgyucht added this pull request to the merge queue Aug 30, 2024
Merged via the queue into databricks:main with commit e00d328 Aug 30, 2024
10 checks passed
mgyucht added a commit that referenced this pull request Sep 4, 2024
@mgyucht
[Release] Release v0.31.0
d3976e3 
### New Features and Improvements

 * Add a way to provide non proxy hosts ([#331](#331)).
 * Add support for discovery URL ([#336](#336)).
 * Provide SSLSocketFactory in HttpClient ([#333](#333)).

### Bug Fixes

 * DatabricksConfig: newWithWorkspaceHost should retain authType ([#338](#338)).
 * Handle login.html incorrect validation for private link ([#340](#340)).

### Internal Changes

 * Fix nightly test failure ([#339](#339)).

### API Changes:

 * Added `regenerateDashboard()` method for `workspaceClient.qualityMonitors()` service.
 * Added `com.databricks.sdk.service.catalog.RegenerateDashboardRequest` and `com.databricks.sdk.service.catalog.RegenerateDashboardResponse` classes.
 * Added `com.databricks.sdk.service.jobs.QueueDetails`, `com.databricks.sdk.service.jobs.QueueDetailsCodeCode`, `com.databricks.sdk.service.jobs.RunLifecycleStateV2State`, `com.databricks.sdk.service.jobs.RunStatus`, `com.databricks.sdk.service.jobs.TerminationCodeCode`, `com.databricks.sdk.service.jobs.TerminationDetails` and `com.databricks.sdk.service.jobs.TerminationTypeType` classes.
 * Added `status` field for `com.databricks.sdk.service.jobs.BaseRun`.
 * Added `status` field for `com.databricks.sdk.service.jobs.RepairHistoryItem`.
 * Added `status` field for `com.databricks.sdk.service.jobs.Run`.
 * Added `status` field for `com.databricks.sdk.service.jobs.RunTask`.
 * Added `maxProvisionedThroughput` and `minProvisionedThroughput` fields for `com.databricks.sdk.service.serving.ServedModelInput`.
 * Added `columnsToSync` field for `com.databricks.sdk.service.vectorsearch.DeltaSyncVectorIndexSpecRequest`.
 * Changed `workloadSize` field for `com.databricks.sdk.service.serving.ServedModelInput` to no longer be required.

OpenAPI SHA: d05898328669a3f8ab0c2ecee37db2673d3ea3f7, Date: 2024-09-04
@mgyucht mgyucht mentioned this pull request Sep 4, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2024
@mgyucht
[Release] Release v0.31.0 (#342)
c0f6987 
### New Features and Improvements

* Add a way to provide non proxy hosts
([#331](#331)).
* Add support for discovery URL
([#336](#336)).
* Provide SSLSocketFactory in HttpClient
([#333](#333)).


### Bug Fixes

* DatabricksConfig: newWithWorkspaceHost should retain authType
([#338](#338)).
* Handle login.html incorrect validation for private link
([#340](#340)).


### Internal Changes

* Fix nightly test failure
([#339](#339)).


### API Changes:

* Added `regenerateDashboard()` method for
`workspaceClient.qualityMonitors()` service.
* Added `com.databricks.sdk.service.catalog.RegenerateDashboardRequest`
and `com.databricks.sdk.service.catalog.RegenerateDashboardResponse`
classes.
* Added `com.databricks.sdk.service.jobs.QueueDetails`,
`com.databricks.sdk.service.jobs.QueueDetailsCodeCode`,
`com.databricks.sdk.service.jobs.RunLifecycleStateV2State`,
`com.databricks.sdk.service.jobs.RunStatus`,
`com.databricks.sdk.service.jobs.TerminationCodeCode`,
`com.databricks.sdk.service.jobs.TerminationDetails` and
`com.databricks.sdk.service.jobs.TerminationTypeType` classes.
 * Added `status` field for `com.databricks.sdk.service.jobs.BaseRun`.
* Added `status` field for
`com.databricks.sdk.service.jobs.RepairHistoryItem`.
 * Added `status` field for `com.databricks.sdk.service.jobs.Run`.
 * Added `status` field for `com.databricks.sdk.service.jobs.RunTask`.
* Added `maxProvisionedThroughput` and `minProvisionedThroughput` fields
for `com.databricks.sdk.service.serving.ServedModelInput`.
* Added `columnsToSync` field for
`com.databricks.sdk.service.vectorsearch.DeltaSyncVectorIndexSpecRequest`.
* Changed `workloadSize` field for
`com.databricks.sdk.service.serving.ServedModelInput` to no longer be
required.

OpenAPI SHA: d05898328669a3f8ab0c2ecee37db2673d3ea3f7, Date: 2024-09-04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht approved these changes

@gopalldb gopalldb Awaiting requested review from gopalldb

@jayantsing-db jayantsing-db Awaiting requested review from jayantsing-db

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samikshya-db @mgyucht @jayantsing-db @vikrantpuppala