-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated Dockerfile so tests would pass and image would build #167
Open
jeffreybreen
wants to merge
5
commits into
databricks:main
Choose a base branch
from
jeffreybreen:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
990d30c
added entry for (Apache) license to classifiers to satisfy pyroma
jeffreybreen b35e519
bumped version of tox and added click and tabulate packages to dev-re…
jeffreybreen 2ef919e
bumped package versions in tox-requirements.txt to resolve conflicts …
jeffreybreen 3f056a7
added installation (and removal) of packages in tox-requirements.txt …
jeffreybreen d202df6
first try to add ability to select export format for recursive export…
jeffreybreen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
tox==2.9.1 | ||
tox==3.2.1 | ||
click==6.7 | ||
tabulate==0.8.2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
# Test reqs | ||
prospector[with_pyroma]==0.12.7 | ||
pylint==1.8.2 | ||
pep8-naming==0.5.0 | ||
pytest==3.2.1 | ||
prospector[with_pyroma]==1.1.1 | ||
pylint==1.9.3 | ||
pep8-naming==0.7.0 | ||
pytest==3.7.1 | ||
mock==2.0.0 | ||
decorator==4.2.1 | ||
rstcheck==3.2 | ||
decorator==4.3.0 | ||
rstcheck==3.3 | ||
pytest-cov | ||
codecov |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a minimal fix here just to also install tox-requirements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is certainly the heart of the change -- and almost enough to fix the issue,
You also need to bump the versions on some of the packages in
tox-requirements.txt
or it will fail due to pytest-django and pyflakes dependencies. Also, you need to add thetabulate
andclick
packages todev-requirements.txt
.My other edits to Dockerfile were an attempt to minimize the resulting image size, but I didn't get a dramatic savings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. I'm a bit concerned about changing the
dev-requirements.txt
andtox-requirements.txt
to make this docker container build work.I think a minimal fix is to intall
tox-requirements.txt
and to move uppip install .
above the./lint.sh
Also it may be useful to add a
.dockerignore
file containingso we don't run into https://stackoverflow.com/questions/44067609/getting-error-importmismatcherror-while-running-py-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with @andrewmchen proposals (add tox-requirements to pip install and moving ./lint.sh) works without problem.
thanks