Create Langchain Genie #5
Merged
+210
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
prithvikannan
commented
Oct 24, 2024
| return {"messages": [AIMessage(content="")]} | ||
|
|
||
|
|
||
| def GenieAgent(genie_space_id, genie_agent_name="Genie", description=""): |
There was a problem hiding this comment.
adding description to the interface, but TBD on how this will be used.
aravind-segu
approved these changes
Oct 24, 2024
|
|
||
| genie = Genie(genie_space_id) | ||
|
|
||
| message = f"I will provide you a chat history, where your name is {genie_agent_name}. Please help with the described information in the chat history.\n" |
There was a problem hiding this comment.
Question here: Are we expecting users to use the genie agent name in their questions? Will the questions be something like:
"Use Genie to get me my financial records"
Will this also work when users ask "Get my financial records"
There was a problem hiding this comment.
The ideal end state is that the user can just specify "Get my financial records". This name is needed so that in a multi-agent (and in the future multi-user) chat array agents can identify who said what.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a
GenieAgentindatabricks_langchain