Client Arguments for DatabricksVectorSearch #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use Service Principals instead of PATs
|
Not sure where the appropriate repository for this change is with the switch over, but I've made it both in this repository and in langchain-ai/langchain-databricks#45 |
There was a problem hiding this comment.
Thanks @chutch1122 for the contribution. I left one small comment to fix the test failures, good to merge once fixed.
integrations/langchain/src/databricks_langchain/vectorstores.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Prithvi Kannan <[email protected]>
Resolve weird line duplication from accepting the proposed change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows new instances of
DatabricksVectorSearchto pass custom arguments to the underlyingVectorSearchClient(imported fromdatabricks.vector_search.client).This allows users to be able to use Service Principal based authentication by passing in
service_principal_client_idorservice_principal_client_secretwithin the newclient_argsparameter.