Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Genie core #13

Merged
merged 11 commits into from
Nov 1, 2024
Merged

Improvements to Genie core #13

merged 11 commits into from
Nov 1, 2024

Conversation

prithvikannan
Copy link
Collaborator

@prithvikannan prithvikannan commented Oct 30, 2024

  • Return markdown format from Genie
  • Add max iterations to Genie polling
  • Trim Genie response if too large
  • Handle Genie failed status

Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
dependencies = [
"typing_extensions",
"pydantic",
"databricks-sdk>=0.34.0",
"pandas",
"tiktoken>=0.8.0",
"tabulate",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed for dataframe to_markdown()

Copy link

@aravind-segu aravind-segu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor nits.

src/databricks_ai_bridge/genie.py Outdated Show resolved Hide resolved
src/databricks_ai_bridge/genie.py Outdated Show resolved Hide resolved
src/databricks_ai_bridge/genie.py Show resolved Hide resolved
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
@prithvikannan prithvikannan merged commit 185bfaf into main Nov 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants