Introduce $DATABRICKS_URL replacement in tests #2158
Merged
+16
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It covers both https://$DATABRICKS_HOST and http://$DATABRICKS_HOST so the test output does not change between local and the cloud.
denik
requested review from
pietern,
andrewnester and
shreyas-goenka
as code owners
denik
changed the title
pietern
approved these changes
Jan 15, 2025
|
Integration test failure is unrelated (TestBundlePipelineRecreateWithoutAutoApprove). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It covers both https://$DATABRICKS_HOST and http://$DATABRICKS_HOST so the test output does not change between local and the cloud.
Tests
Existing tests using golden files (acceptance and integration) catch this and were updated.