Migrate more variable tests to acceptance #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
pietern,
andrewnester and
shreyas-goenka
as code owners
denik
force-pushed
the
denik/TestResolveComplexVariable
branch
from
d17a71b to
ba7e37f
Compare
denik
changed the title
denik
force-pushed
the
denik/TestResolveComplexVariable
branch
from
1e56ef1 to
3c3b76e
Compare
|
Integration test failure is unrelated. |
pietern
reviewed
Jan 15, 2025
| name: TestResolveComplexVariable | ||
|
|
||
| variables: | ||
| type: "complex" |
There was a problem hiding this comment.
The warning is legit, this belongs one level deeper.
There was a problem hiding this comment.
Thanks! Fixed in 4028584
pietern
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.