Run tests with coverage on CI #2141
Draft
+9
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
force-pushed
the
denik/coverage-ci
branch
from
843ccf6 to
e9acfbf
Compare
denik
added a commit
that referenced
this pull request
Jan 15, 2025
## Changes When setting up PATH in tests, put desired entry first but keep the rest as well. Otherwise it fails on Windows ``` D:/a/cli/cli/libs/exec/exec_test.go:108 Error: Received unexpected error: exit status 0xc0000135 ``` Explanation from Claude: > The error code 0xc0000135 is a Windows error indicating "Unable to locate DLL" > When code coverage is enabled, Go instruments the binary with coverage tracking code, which requires additional DLL dependencies on Windows. ## Tests Separate draft PR with coverage enabled on CI: #2141
denik
force-pushed
the
denik/coverage-ci
branch
from
840dc2e to
ef634a9
Compare
Combine 'make cover' and 'make acc-cover' into single command. They still write coverage into different files -- it would be useful to see separate coverage numbers.
denik
force-pushed
the
denik/coverage-ci
branch
from
ef634a9 to
6be556e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine 'make cover' and 'make acc-cover' into single command. They still write coverage into different files -- it would be useful to see separate coverage numbers.