Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: possible null pointer dereference #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rng70-or
Copy link

In file: LinkCommandLine.java, class LinkCommandLine there is a method addDynamicInputLinkOptions that, there is a potential Null pointer dereference while calling the equals method.

PathFragment libDir = inputArtifact.getExecPath().getParentDirectory();

The method getParentDirectory() can return null value.

public PathFragment getParentDirectory() {
    return segments.length == 0 ? null : subFragment(0, segments.length - 1);
}

now if the returned value is null then it later can raise a NullPointerException

!libDir.equals(solibDir)

but changing the order it can be avoided or a null check on libDir should be done to avoid this kind error. like

!solibDir.equals(libDir)

or

libDir != null
Sponsorship and Support

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant