Feature: Abstract Vote
#1292
Open
Feature: Abstract Vote
#1292
+475
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added an associated type `Vote: RaftVote` to `RaftTypeConfig`, allowing applications to customize the `Vote` implementation. - Introduced the `OrdBy` trait with the method `fn ord_by() -> Option<Ordering>` to enable customized ordering for types. This trait is used internally only for determine `RaftVote` order. The ordering logic is consistent across different `Vote` implementations and does not require the application to implement `PartialOrd` directly for `Vote`. Instead, this ordering property is provided by OpenRaft. - Implemented `RaftVote` for the struct `Vote`, which serves as the default `RaftVote` implementation. This ensures that applications upgrading OpenRaft do not need to make any changes. - Part of databendlabs#1278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Feature: Abstract
VoteAdded an associated type
Vote: RaftVotetoRaftTypeConfig,allowing applications to customize the
Voteimplementation.Introduced the
OrdBytrait with the methodfn ord_by() -> Option<Ordering>to enable customized ordering for types.This trait is used internally only for determine
RaftVoteorder.The ordering logic is consistent across different
Voteimplementations and does not require the application to implement
PartialOrddirectly forVote. Instead, this ordering property isprovided by OpenRaft.
Implemented
RaftVotefor the structVote, which serves as thedefault
RaftVoteimplementation. This ensures that applicationsupgrading OpenRaft do not need to make any changes.
Part of Abstract OpenRaft Core Data Structures into Traits #1278
This change is