Change: change Vote<NID:NodeId> to Vote<C:RaftTypeConfig>

[drmingdrmer]

Changelog

Change: change Vote<NID:NodeId> to Vote<C:RaftTypeConfig>

This refactoring moves Vote from a per-NodeId type to a per-TypeConfig type,
to make it consistent with RaftTypeConfig usage across the codebase.

• Part of: Abstract OpenRaft Core Data Structures into Traits #1278

Upgrade tip:

Vote is now parameterized by RaftTypeConfig instead of NodeId

• Change Vote<NodeId> to Vote<C> where C: RaftTypeConfig, for
  example, change Vote<u64> to Vote<YourTypeConfig>.

---

This change is 

[drmingdrmer]

To address #1278, types like Vote<NID>, LeaderId<NID>, and LogId<NID> need to be updated to use RaftTypeConfig. This configuration encapsulates all customizable associated types, rather than relying on a single NID: NodeID.

[lichuang]

dose change Vote definition need to do some backward compatibility test?say: save some Vote data of old format, and read it using new format.

[drmingdrmer]

dose change Vote definition need to do some backward compatibility test?say: save some Vote data of old format, and read it using new format.

No. There is no data format change. The only thing changed is the way to declare the data format: Vote<NID> -> Vote<RaftTypeConfig>

[lichuang]

dose change Vote definition need to do some backward compatibility test?say: save some Vote data of old format, and read it using new format.

No. There is no data format change. The only thing changed is the way to declare the data format: Vote<NID> -> Vote<RaftTypeConfig>

i see the new definition is

pub struct Vote<C: RaftTypeConfig> {
    /// The id of the node that tries to become the leader.
    pub leader_id: LeaderId<C::NodeId>,

    pub committed: bool,
}

so there is no format change. but my question is: since the new and old definition declare id as C::NodeId, what the point introduce RaftTypeConfig param instead of NID: NodeId?

[drmingdrmer]

so there is no format change. but my question is: since the new and old definition declare id as C::NodeId, what the point introduce RaftTypeConfig param instead of NID: NodeId?

In order to allow to define all of the data types in protobuf, such as Vote, LeaderId, LogId, these types can not use a Rust type field. But instead, they must reference the types with C::XXX, for example:

struct Vote<NID> {
 leader_id: LeaderId<_>,
 // ..
}

Should be updated to

struct Vote<C> {
 leader_id: C::LeaderId,
}

[SteveLauC]

Reviewed 47 of 47 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @schreter)