Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): clickhouse endpoints env variable name typo (#78) #79

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

washanhanzi
Copy link
Contributor

@washanhanzi washanhanzi commented Oct 11, 2023

Fix #78

This PR also change the QUERY_CLICKHOUSE_HTTP_HANDLER_PORT from 9000 to 8124. It is changed in #68, but the env variable name has a typo, it never take into effect.

I think this is just temporary fix. PR #77 use the user defined ports for the statefulSet, but the statefulSet template file has its own env variables defined.

Those two sets of ports can be easily unsynced as shown in #68.

This should be documented in values.yaml for now, else the user defined ports has no use.

I think those ports should be listed as separate and dedicate yaml values, and then used for env variables and statefulSet and service. User shouldn't define the port name, and it better not ranged in template.

@everpcpc
Copy link
Member

thanks!

@everpcpc everpcpc merged commit 3f91ce4 into databendlabs:main Oct 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typo in clickhouse endpoints environment variable names
2 participants