fix(query): clickhouse endpoints env variable name typo (#78) #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #78
This PR also change the
QUERY_CLICKHOUSE_HTTP_HANDLER_PORT
from9000
to8124
. It is changed in #68, but the env variable name has a typo, it never take into effect.I think this is just temporary fix. PR #77 use the user defined ports for the statefulSet, but the statefulSet template file has its own env variables defined.
Those two sets of ports can be easily unsynced as shown in #68.
This should be documented in
values.yaml
for now, else the user defined ports has no use.I think those ports should be listed as separate and dedicate yaml values, and then used for env variables and
statefulSet
andservice
. User shouldn't define the port name, and it better notranged
in template.