feat: Rewriting the value parser #149
Open
+759
−213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
forsaken628
commented
Jan 21, 2025
forsaken628
commented
- the old value parser did not conform to the standard library documentation. driver.Value should be a small number of types, and then the standard library implements conversions to a wider range of types.
- provide unknownColumnType for compatibility with newly added types.
- passes ttc integration tests.
- this PR supports fewer types than the previous one.
- need to add support for complex types. That is, add Struct, through the implementation of the Scanner interface, to complete the parsing driver.Value.
|
cc @flaneur2020 |
flaneur2020
reviewed
Jan 21, 2025
| @@ -77,6 +77,10 @@ func (dc *DatabendConn) BeginTx( | |||
| return &databendTx{dc}, nil | |||
| } | |||
|
|
|||
| func (dc *DatabendConn) DataParserOptions() *DataParserOptions { | |||
There was a problem hiding this comment.
is this required to be public to users?
everpcpc
approved these changes
Jan 21, 2025
sundy-li
reviewed
Jan 22, 2025
| if c.checkNull(s) { | ||
| return nil, nil | ||
| } | ||
| return time.ParseInLocation("2006-01-02 15:04:05.999999", s, time.UTC) |
There was a problem hiding this comment.
the timezone should be fetched from settings I think.
There was a problem hiding this comment.
But we don't have client side timezone, maybe we can keep it let it use UTC now.
I checked bendsql it's also using native date
sundy-li
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.